Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #20555 Meta Keywords/Meta Description are input field in product form while they are defined as textarea #20556

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fixed issue #20555 Meta Keywords/Meta Description are input field in product form while they are defined as textarea #20556

merged 1 commit into from
Feb 13, 2019

Conversation

amitvishvakarma
Copy link
Contributor

@amitvishvakarma amitvishvakarma commented Jan 24, 2019 •
edited by aleron75
Loading

Fixed issue #20555 Meta Keywords/Meta Description are input field in product form while they are defined as textarea

Description (*)

Fixed issue #20555 Meta Keywords/Meta Description are input field in product form while they are defined as textarea

Fixed Issues (if relevant)

  1. magento/magento2 Meta Keywords/Meta Description are input field in product form while they are defined as textarea #20555: Meta Keywords/Meta Description are input field in product form while they are defined as textarea

Manual testing scenarios (*)

  1. Go to Store->Attributes->Product.
  2. Search for Meta Keywords/Meta description.
  3. View them, you will able to see their 'Catalog Input Type for Store Owner' is Textarea.
  4. Now go to Catalog->Product
  5. Click on 'Add Product button' Or Edit Product.
  6. Go to Search engine optimization tab.
  7. You will see Meta Keywords/Meta description are showing text field instead of textarea.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@amitvishvakarma
Fixed issue related to Meta Keywords/Description
a5dfa0d 
Fixed issue related to Meta Keywords/Description
@magento-engcom-team
Copy link
Contributor

Hi @amitcedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 24, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aleron75 aleron75 self-assigned this Jan 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-4180 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@amitcedcoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 13, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit a5dfa0d into magento:2.3-develop Feb 13, 2019
@ghost
Copy link

ghost commented Feb 13, 2019

Hi @amitcedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2019
@sidolov
ENGCOM-4180: Fixed issue #20555 Meta Keywords/Meta Description are in…
cb02a87 
…put field in product form while they are defined as textarea #20556
@amol2jcommerce amol2jcommerce mentioned this pull request Feb 13, 2019
Merged
4 tasks
@sidolov sidolov added this to the Release: 2.3.2 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

Assignees

@aleron75 aleron75

Labels
Award: bug fix Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@amitvishvakarma @magento-engcom-team @magento-cicd2 @aleron75 @sidolov